internal/exec/validate_stacks.go (2)

89-110: LGTM! Clear and robust schema validation logic

The implementation effectively handles the default schema setting and provides comprehensive error handling. The trace logging helps with debugging, and the error message is informative.

A small enhancement suggestion: Consider adding the default schema URL to the error message to make it clear what URL will be used if none is specified.

Here's the suggested improvement for the error message:

 return fmt.Errorf("the Atmos JSON Schema file '%s' does not exist.\n"+
 			"It can be configured in the 'schemas.atmos.manifest' section in 'atmos.yaml', or provided using the 'ATMOS_SCHEMAS_ATMOS_MANIFEST' "+
 			"ENV variable or '--schemas-atmos-manifest' command line argument.\n"+
 			"The path to the schema file should be an absolute path or a path relative to the 'base_path' setting in 'atmos.yaml'. \n"+
-			"Alternatively, you can specify a schema file using a URL that will be downloaded automatically.",
+			"Alternatively, you can specify a schema file using a URL that will be downloaded automatically.\n"+
+			"If not specified, the default schema URL '%s' will be used.",
-			cliConfig.Schemas.Atmos.Manifest)
+			cliConfig.Schemas.Atmos.Manifest, atmosManifestDefault)

---

100-103: Consider adding retry mechanism for schema downloads

Network requests to download the schema can fail temporarily. Consider implementing a retry mechanism with exponential backoff for better reliability.

Example implementation using a simple retry loop:

+func downloadWithRetry(client *getter.Client, maxRetries int) error {
+    var err error
+    for i := 0; i < maxRetries; i++ {
+        if err = client.Get(); err == nil {
+            return nil
+        }
+        time.Sleep(time.Second * time.Duration(1<<uint(i)))
+    }
+    return err
+}

 func downloadSchemaFromURL(manifestURL string) (string, error) {
     // ... existing code ...
-    if err = client.Get(); err != nil {
+    if err = downloadWithRetry(client, 3); err != nil {
         return "", fmt.Errorf("failed to download the Atmos JSON Schema file '%s' from the URL '%s': %w", fileName, manifestURL, err)
     }
     return atmosManifestJsonSchemaFilePath, nil
 }

Configuration used: .coderabbit.yaml
Review profile: CHILL

internal/exec/validate_stacks.go (1)

105-110: Consider making the error message more concise.

The current error message is quite verbose. Consider restructuring it to be more scannable while maintaining the essential information.

-		return fmt.Errorf("the Atmos JSON Schema file '%s' does not exist.\n"+
-			"It can be configured in the 'schemas.atmos.manifest' section in 'atmos.yaml', or provided using the 'ATMOS_SCHEMAS_ATMOS_MANIFEST' "+
-			"ENV variable or '--schemas-atmos-manifest' command line argument.\n"+
-			"The path to the schema file should be an absolute path or a path relative to the 'base_path' setting in 'atmos.yaml'. \n"+
-			"Alternatively, you can specify a schema file using a URL that will be downloaded automatically.",
+		return fmt.Errorf("Schema file '%s' not found. Configure via:\n"+
+			"1. 'schemas.atmos.manifest' in atmos.yaml\n"+
+			"2. ATMOS_SCHEMAS_ATMOS_MANIFEST env var\n"+
+			"3. --schemas-atmos-manifest flag\n\n"+
+			"Accepts: absolute path, relative to base_path, or URL",
			cliConfig.Schemas.Atmos.Manifest)

Configuration used: .coderabbit.yaml
Review profile: CHILL

#!/bin/bash
# Description: Verify schema URL accessibility and JSON validity
curl -s -f -L https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json | jq . >/dev/null
if [ $? -eq 0 ]; then
    echo "Schema URL is accessible and returns valid JSON"
else
    echo "Failed to validate schema URL"
fi